Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: spotify/SPTPersistentCache
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: spotify/SPTPersistentCache
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: nullability-audit
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 15 files changed
  • 1 contributor

Commits on Feb 21, 2016

  1. Reorder parameters of cache creation method in tests 

    - This changes the block to be the last parameter. Making it in line
with our naming guidelines and it works better with Xcode’s indentation.
    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    0f550c5 View commit details
    Browse the repository at this point in the history

  2. Audit Record class for nullability

    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    4326886 View commit details
    Browse the repository at this point in the history

  3. Audit Response class for nullability

    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    d7b09a5 View commit details
    Browse the repository at this point in the history

  4. Audit Header types and functions for nullability

    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    70cae2f View commit details
    Browse the repository at this point in the history

  5. Remove extraneous convenience Options init 

    - It only reduced the number of parameters by two. Which are easy to
supply anyways. Further there’s already an even easier convenience
initializer to user, -init.
    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    6950732 View commit details
    Browse the repository at this point in the history

  6. Fix memory semantics

    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    23412ee View commit details
    Browse the repository at this point in the history

  7. Change parameter label debug -> debugCallback

    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    16e3b03 View commit details
    Browse the repository at this point in the history

  8. Move currentTimeCallback parameter to second last 

    - Block parameters should be at the end of the parameter list.
    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    59e6975 View commit details
    Browse the repository at this point in the history

  9. Move framework version constants to top of file 

    - It should be up there :)
    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    eda7e9f View commit details
    Browse the repository at this point in the history

  10. Move SPTPersistentCacheChooseKeyCallback to header where it’s used 

    - It’s unused by the Options class.
    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    22fc9dc View commit details
    Browse the repository at this point in the history

  11. Fix remaining usage of old Options init

    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    5dfc9a6 View commit details
    Browse the repository at this point in the history

  12. Audit Options class for nullability 

    - Required some refactoring of the -init. First and foremost changing
from early return to `if (self) { do-init }`.
- Also took the liberty to clean up the file a bit. There’s still work
to be done in that regard though.
    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    9ed7f05 View commit details
    Browse the repository at this point in the history

  13. Audit FileManager class for nullability

    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    83bd952 View commit details
    Browse the repository at this point in the history

  14. Audit SPTPersistentCache part 1 

    - Resolves duplication of properties
- Resolves use of property access in -init.
- Resolves some style issues in the implementation.
- Updates tests to use a local version which can override the
properties needed for the tests. So that this cannot be done in
production.
    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    589e70d View commit details
    Browse the repository at this point in the history

  15. Audit SPTPersistentCache for nullability 

    - Also adds Objective-C generics type hinting.
- Hack the tests to trick the static analyzer.
    @rastersize
    rastersize committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    75cb7dc View commit details
    Browse the repository at this point in the history
Loading