Skip to content
This repository has been archived by the owner on Jan 17, 2019. It is now read-only.

Alternative to https://github.com/spotify/HubFramework/pull/283 #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marmelroy
Copy link
Contributor

Traversing the view hierarchy in search of specific class that handle touches is not really scalable.

This is an alternative solution.

@spotify-ci-bot
Copy link

2 Errors
🚫 HubFrameworkDemoUITests.ReloadUITests: testReloadingContent, UI Testing Failure - Neither element nor any descendant has keyboard focus. Element:
ReloadUITests.swift#L51
🚫 Tests have failed, see below for more information.
3 Messages
📖 Executed 343 tests, with 0 failures (0 unexpected) in 7.452 (8.802) seconds
📖 Executed 340 tests, with 0 failures (0 unexpected) in 7.204 (8.524) seconds
📖 Executed 9 tests, with 1 failure (0 unexpected) in 140.900 (140.918) seconds

Tests:

Classname Name Time
ReloadUITests testReloadingContent() 25.472521007061005

Generated by 🚫 danger

@rastersize
Copy link
Contributor

@mumme @marmelroy I prefer this solution a lot to what Hub framework does and what was added in #283! Seems like a better way to do it.

Copy link
Contributor

@rastersize rastersize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😼🤝👾

@mumme
Copy link
Contributor

mumme commented Feb 15, 2017

This solution did not work for the segmented control case.

@marmelroy
Copy link
Contributor Author

@mumme, did a little investigation and it appears that the reason this doesn't work is that UISegementedControl doesn't implement any gesture recognisers and captures touches directly (thanks Apple).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants