interactions in given/setup blocks should have precedence over those in setup methods

[robfletcher]

Originally reported on Google Code with ID 199

Describe the enhancement you have in mind.

interactions in given/setup blocks should have precedence over those in setup methods
as discussed in: http://groups.google.com/group/spockframework/browse_thread/thread/3e20f7466dd6248b

Is it possible to override the behaviour (return value) for one
specific test method: see example below (also available at:
http://meetspock.appspot.com/script/36001)
"testing exceptional behaviour" fails where I want it to succeed

interface MyInterface {
    int myMethod()

}

class MyInterfaceTest extends Specification {
    def myInterface = Mock(MyInterface)

    def setup() {
        myInterface.myMethod() >> 1
    }

    def "testing regular behaviour"() {
        when:
         def result = myInterface.myMethod()
        then:
         result == 1
     }

    def "testing exceptional behaviour"() {
        given:
         myInterface.myMethod() >> 2
        when:
         def result = myInterface.myMethod()
        then:
         result == 2
      } 
}

Which particular problem would this enhancement solve for you?
it would ease the setup of testing expetional behaviour, where for all other tests
use the same 'normal' behaviour of the mock, so you don't have to setup this for each
test.


Please provide any additional information below. You can also assign
labels.

Reported by frederic.pape on 2011-09-13 11:08:13

[robfletcher]

It would make more sense to me to override the interactions defined in the setup method
within the setup/given block

Reported by Alessandro.Mecca on 2012-11-20 16:52:59

[robfletcher]

I completely agree with this change. Just like in junit any changes I make to mocks
or global variables are overridden in an individual test. I found it very confusing
when I would change the behavior in an individual tests setup block to find out it
is ignored. The specification setup should be to setup the base line for all tests.
Then each individual test should be able to change behavior as it sees fit.

Reported by Chef098 on 2013-07-05 14:35:29

[robfletcher]

+1 This change also makes easier to migrate from testng or junit to Spock, as it is
the default behaviour on these frameworks.

Reported by fsamir on 2015-07-16 05:35:45

[alwinmark]

+1

[alwinmark]

As a workaround while keeping the Behaviour Definition at the right place, I did currently sth like this:

class MyInterfaceTest extends Specification {
    def myInterface = Mock(MyInterface)
    def myMethodReturn

    def setup() {
        myMethodReturn = 1
        myInterface.myMethod() >> {return myMethodReturn}
    }

    def "testing regular behaviour"() {
        when:
         def result = myInterface.myMethod()
        then:
         result == 1
     }

    def "testing exceptional behaviour"() {
        given:
         myMethodReturn = 2
        when:
         def result = myInterface.myMethod()
        then:
         result == 2
      } 
}

[sf-git]

+1

[mjwest10]

+1

[pauxus]

I think the best way to do this while retaining a) backward compatibility and b) make it optional (sometime I don't want it to be overriden) would be a new syntax/method, something like:

def "overriding setup mocks"() {
    given:
    myMock.redefine {
        oldMethod >> "bla"
    }

    ....
}

[mjwest10]

That would work great!

[vanta]

+1

This issue was created in 2011, any update on it? It's still marked "New"...

[EduardoSolanas]

+1 any news regarding this? I am selling finally to my new team Spock, and this is one of the things that is confusing for them coming from Junit