You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Occasionally. it is confusing to have junit-platform-testkit provided as an optional spock-core dependency (with its own dependencies). Namely here and here.
Proposed solution
As regular tests with Spock don't need EmbeddedSpecRunner nor junit-platform-testkit it would be good to extract the related stuff (probably also with EmbeddedSpecification) to a separate publishable module (spock-testkit?) to make it used as a dependency for the Spock plugin writers or the people writing more sophisticated tests (which need to reproduce a complete (embedded) Spock life-cycle in Spock tests).
The text was updated successfully, but these errors were encountered:
I am hesitant to create a new module just to have a few classes in there. Would it suffice to update the Javadoc. It already states that its mostly for spock internally.
* Utility class that allows to run (fragments of) specs programmatically.
* Mainly intended for spec'ing Spock itself.
We could add a notice that its usage requires the junit-platform-testkit dependency. We already have several optional dependencies, e.g. byte-buddy, so the concept is not new.
The concept is not new, but for the other dependencies there is a clear and obvious error message. If the testkit is missing it is more a subtle crypted error message.
In addition, byte-buddy or objenesis are used in regular testing (just with spying). However, EmbeddedSpecRunner is much more sophisticated tool for plugin writers or some dirty hacks. Having ~60 hits globally on GitHub for EmbeddedSpecRunner (let's skip related classes which also could be used) shows the scale. I can add a dependency manually (if needed) and I know what to expect (instead of a weird exception related to AssertJ).
Issue description
Occasionally. it is confusing to have
junit-platform-testkit
provided as an optionalspock-core
dependency (with its own dependencies). Namely here and here.Proposed solution
As regular tests with Spock don't need
EmbeddedSpecRunner
norjunit-platform-testkit
it would be good to extract the related stuff (probably also withEmbeddedSpecification
) to a separate publishable module (spock-testkit
?) to make it used as a dependency for the Spock plugin writers or the people writing more sophisticated tests (which need to reproduce a complete (embedded) Spock life-cycle in Spock tests).The text was updated successfully, but these errors were encountered: