Skip to content

.conf CRUD functionality added #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 10, 2022
Merged

.conf CRUD functionality added #141

merged 11 commits into from
Jan 10, 2022

Conversation

vmalaviya-splunk
Copy link
Contributor

No description provided.

@vmalaviya-splunk vmalaviya-splunk self-assigned this Nov 19, 2021
fantavlik
fantavlik requested changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really close, some minor comments and questions. I wonder if we could provide a simple example of how to use this also? The test has some of this but it would be nice to have just a few lines demonstrating the change (in the README)

@vmalaviya-splunk
Structural changes for .conf CRUD functionality
034e411 
1. Method renamed: doesFileExist --> getConfFile
2. Method renamed: doesStanzaExist --> getStanza
3. try/catch removed to let exception propagate to calling method
4. return file/stanza if found or else return null
@vmalaviya-splunk
Update README.md
422d4d6
@vmalaviya-splunk
Refactoring
7b54651
fantavlik
fantavlik requested changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two fairly minor comments and then I think this is ready to merge

@vmalaviya-splunk
README and test updated
5fa52e6 
README and test updated to use actual example for .conf file
@vmalaviya-splunk
Doc string added for new methods
381f8aa
fantavlik
fantavlik approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks for working through all the rounds of review!

@vmalaviya-splunk vmalaviya-splunk merged commit 5014298 into develop Jan 10, 2022
@vmalaviya-splunk vmalaviya-splunk mentioned this pull request Mar 7, 2022
Merged
@ashah-splunk ashah-splunk deleted the DVPL-7124 branch April 20, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantavlik fantavlik fantavlik approved these changes

@zenmoto zenmoto Awaiting requested review from zenmoto

Assignees

@vmalaviya-splunk vmalaviya-splunk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmalaviya-splunk @fantavlik