CSPL-3357: Enforce Acknowledgment of Splunk General Terms (SGT) #1496
Conversation
…nto CSPL_3357_configmap
rlieberman-splunk
changed the title
rlieberman-splunk
requested review from
vivekr-splunk,
michal-tatusko-splunk,
patrykw-splunk,
Igor-splunk and
kasiakoziol
| @@ -16,6 +16,11 @@ SPLUNK_ENTERPRISE_IMAGE ?= "docker.io/splunk/splunk:edge" | |||
| # add namespace to this | |||
| WATCH_NAMESPACE ?= "" | |||
|
|
|||
| # SPLUNK_GENERAL_TERMS is used for the mandatory acknowledgment mechanism for | |||
| # the Splunk General Terms (SGT) https://www.splunk.com/en_us/legal/splunk-general-terms.html. | |||
| # The value must be manually set to "--accept-current-at-splunk-com" | |||
There was a problem hiding this comment.
Is there way to simplify this to say "ACCEPT_SPLUNK_GENERAL_TERMS" and value as "yes" or "no" . and in the code we can pass "--accept-current-at-splunk-com" to docker image
There was a problem hiding this comment.
I am waiting to hear from the legal team, but we might need the user to manually put in the full acceptance. I will reach out and ask them.
There was a problem hiding this comment.
From Elizabeth Flemin from the legal team: "Unfortunately we need them to pass the exact argument - yes or no would go around the purpose of changing it."
| if os.Getenv("SPLUNK_GENERAL_TERMS") == "--accept-current-at-splunk-com" { | ||
| return nil | ||
| } | ||
| return fmt.Errorf("SPLUNK_GENERAL_TERMS environment variable must be set to \"--accept-current-at-splunk-com\". Update the splunk-operator-controller-manager deployment") |
There was a problem hiding this comment.
add an k8s event here
There was a problem hiding this comment.
can we also change the status of the CR to show the status message why its failing
This description was generated in part by GitHub Copilot.
Description
This pull request introduces changes to support a mandatory acknowledgment mechanism for the Splunk General Terms (SGT) in the Splunk Operator for Kubernetes. The updates include adding a new
SPLUNK_GENERAL_TERMSenvironment variable, modifying deployment configurations, and updating documentation to guide users on the new requirements.Key Changes
Configuration Updates
SPLUNK_GENERAL_TERMSwith a default empty value in multiple configuration files, includingMakefile,kustomization.yaml, and deployment manifests. This variable must be set to"--accept-current-at-splunk-com"to comply with the SGT acknowledgment mechanism. [1] [2] [3] [4] [5]Deployment Behavior
SPLUNK_GENERAL_TERMSvariable, ensuring it is passed during deployment or artifact generation. [1] [2] [3]Documentation Enhancements
README.mdanddocs/Install.mdon how to configure theSPLUNK_GENERAL_TERMSvariable during deployment. [1] [2]SplunkGeneralTermsMigration.md, explaining the motivation, impact, and migration steps for the SGT acknowledgment mechanism.Minor Fixes
docs/AppFramework.md(changed "LicenceManager" to "LicenseManager").Testing and Verification
Related Issues
PR Checklist