Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qbec validate should do a server-side dry-run #237

Open
melugoyal opened this issue May 25, 2021 · 2 comments
Open

qbec validate should do a server-side dry-run #237

melugoyal opened this issue May 25, 2021 · 2 comments

Comments

@melugoyal
Copy link

qbec validate should perform a server-side dry-run using the options provided here. this will ensure the validate step runs through admission webhooks configured on the Kubernetes API server, and make the validation more meaningful.

@gotwarlost
Copy link
Contributor

@sherman-grewal - super-useful feature. Should be an opt-in and not turned on by default.

@harsimranmaan
Copy link
Contributor

harsimranmaan commented Oct 9, 2021

When implemented, this feature should be used with caution as there could be admission webhooks with side-effects. See https://kubernetes.io/docs/reference/using-api/api-concepts/#make-a-dry-run-request for details. For API servers not supporting the dry-run=server this could result in persistence. https://github.com/kubernetes/kubectl/blob/a8d3024f1144e77593d35c3f46ce4fd09c83de96/pkg/cmd/apply/apply.go#L419-L425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants