Pex 552/on demand detection triggers #416
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyth0n1c
commented
Jun 16, 2025
| time_to_execute = 0 | ||
|
|
||
| # Check if the job is finished | ||
| while not job.is_done(): |
There was a problem hiding this comment.
dispatch() appears to take a **kwargs argument. Instead of using the while loop, can we just pass a {'exec_mode': 'blocking'} as we do for unit testing?
There was a problem hiding this comment.
Just check the description of the parameter (If set to blocking, returns the sid when the job is complete.), exec_mode sounds to be a better way than while loop! Would change it and test with pipeline later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For integration testing, instead of scheduling a savedsearch to run and waiting a predefined amount of time, use the API to call the search right away. This can be a significant improvement in terms of the amount of time spent waiting for RBA/Notable artifacts to be generated.