Skip to content

Remove use enum values #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Remove use enum values #335

merged 9 commits into from
Dec 12, 2024

Conversation

pyth0n1c
Copy link
Contributor

@pyth0n1c pyth0n1c commented Dec 4, 2024

Remove the use of all use_enum_values in Pydantic Models.
Secondly, clean up the use of .value when checking/comparing the values of enums in the codebase.

multiple inheritance, to StrEnum
or IntEnum
However, this has not received any testing yet.
now that they have been more
strictly defined as IntEnum or
StrEnum.
This has not yet been tested.
…StrEnum and IntEnum when writing YMLs from objects that contain them.
new_content.py
that restated it. but this is not necessary
if they inherit from SecurityContentObject
@ljstella ljstella self-requested a review December 12, 2024 18:44
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests successfully against associated security_content PR

@pyth0n1c pyth0n1c merged commit 9eb642a into contentctl_5 Dec 12, 2024
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants