Support the use of primary keys other than "id" in ActiveRecord.#237
Merged
mcmire merged 1 commit intosplitwise:mainfrom Apr 25, 2024
Merged
Conversation
benk-gc
force-pushed
the
benk--support-custom-primary-key-fields-activerecord
branch
from
cb9b75c to
4695d54
Compare
Previously the diffing code made an assumption that "id" would always be the primary field. This is not always the case. Additionally, the use of read_attribute(:id) is deprecated in rails/rails@39997a0. This changes adds support for use of custom primary key fields, and updates the Person test model to use the "person_id" primary key. Note that this will almost certainly still run into issues if the model uses the newly introduced composite primary key type, so this would require additional changes outside the scope of this fix.
benk-gc
force-pushed
the
benk--support-custom-primary-key-fields-activerecord
branch
from
4695d54 to
7ffc318
Compare
Contributor
Author
|
@mcmire Any chance you could approve the test workflow and give this one a look? This would unblock us using the gem in Rails 7.1. Thanks! |
Contributor
Author
|
@mcmire Specs looks happy - what do you think about a merge + release for this one? Happy to make any changes. |
Contributor
Author
|
@mcmire Ping on the above when you have a sec - thanks! |
mcmire
approved these changes
Apr 25, 2024
Collaborator
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Sorry about the delay in reviewing. Looks good. Thank you!
Collaborator
|
I've released this under 0.12.0: https://github.com/mcmire/super_diff/releases/tag/v0.12.0. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the diffing code made an assumption that "id" would always be the primary field. This is not always the case, and the use of
read_attribute(:id)is deprecated in rails/rails@39997a0.This changes adds support for use of custom primary key fields, and updates the Person test model to use the "person_id" primary key.
Note that this will almost certainly still run into issues if the model uses the newly introduced composite primary key type, so this would require additional changes outside the scope of this fix.