Fixing more tests

Author: mcmire

spec/unit/deprecations_spec.rb

@@ -1,11 +1,7 @@
 require "spec_helper"
 
 # stree-ignore
-constant_remappings = {
-  "SuperDiff::ActiveRecord::ObjectInspection::InspectionTreeBuilders::ActiveRecordModel" => "SuperDiff::ActiveRecord::InspectionTreeBuilders::ActiveRecordModel",
-  "SuperDiff::ActiveRecord::ObjectInspection::InspectionTreeBuilders::ActiveRecordRelation" => "SuperDiff::ActiveRecord::InspectionTreeBuilders::ActiveRecordRelation",
-  "SuperDiff::ActiveSupport::ObjectInspection::InspectionTreeBuilders::HashWithIndifferentAccess" => "SuperDiff::ActiveSupport::InspectionTreeBuilders::HashWithIndifferentAccess",
-  "SuperDiff::ActiveSupport::ObjectInspection::InspectionTreeBuilders::OrderedOptions" => "SuperDiff::ActiveSupport::InspectionTreeBuilders::OrderedOptions",
+common_constant_remappings = {
   "SuperDiff::ColorizedDocumentExtensions" => "SuperDiff::Core::ColorizedDocumentExtensions",
   "SuperDiff::Configuration" => "SuperDiff::Core::Configuration",
   # TODO: Add back?
@@ -87,7 +83,19 @@
   "SuperDiff::TieredLinesFormatter" => "SuperDiff::Core::TieredLinesFormatter",
 }
 
-constant_remappings.each do |old_constant_name, new_constant_name|
+# stree-ignore
+active_record_constant_remappings = {
+  "SuperDiff::ActiveRecord::ObjectInspection::InspectionTreeBuilders::ActiveRecordModel" => "SuperDiff::ActiveRecord::InspectionTreeBuilders::ActiveRecordModel",
+  "SuperDiff::ActiveRecord::ObjectInspection::InspectionTreeBuilders::ActiveRecordRelation" => "SuperDiff::ActiveRecord::InspectionTreeBuilders::ActiveRecordRelation",
+}
+
+# stree-ignore
+active_support_constant_remappings = {
+  "SuperDiff::ActiveSupport::ObjectInspection::InspectionTreeBuilders::HashWithIndifferentAccess" => "SuperDiff::ActiveSupport::InspectionTreeBuilders::HashWithIndifferentAccess",
+  "SuperDiff::ActiveSupport::ObjectInspection::InspectionTreeBuilders::OrderedOptions" => "SuperDiff::ActiveSupport::InspectionTreeBuilders::OrderedOptions",
+}
+
+common_constant_remappings.each do |old_constant_name, new_constant_name|
   RSpec.describe old_constant_name, type: :unit do
     it "maps to #{new_constant_name}" do
       capture_warnings do
@@ -103,6 +111,38 @@
   end
 end
 
+active_record_constant_remappings.each do |old_constant_name, new_constant_name|
+  RSpec.describe old_constant_name, type: :unit, active_record: true do
+    it "maps to #{new_constant_name}" do
+      capture_warnings do
+        expect(Object.const_get(old_constant_name)).to be(
+          Object.const_get(new_constant_name)
+        )
+      end
+    end
+
+    it "points users to #{new_constant_name} instead" do
+      expect(old_constant_name).to be_deprecated_in_favor_of(new_constant_name)
+    end
+  end
+end
+
+active_support_constant_remappings.each do |old_constant_name, new_constant_name|
+  RSpec.describe old_constant_name, type: :unit, active_support: true do
+    it "maps to #{new_constant_name}" do
+      capture_warnings do
+        expect(Object.const_get(old_constant_name)).to be(
+          Object.const_get(new_constant_name)
+        )
+      end
+    end
+
+    it "points users to #{new_constant_name} instead" do
+      expect(old_constant_name).to be_deprecated_in_favor_of(new_constant_name)
+    end
+  end
+end
+
 RSpec.describe "SuperDiff::Differs::Main.call", type: :unit do
   it "maps to SuperDiff.diff" do
     capture_warnings do