Add HTTP/HTTPS proxy support for corporate environments #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Integrated `https-proxy-agent` for corporate proxy configuration in sdk.js. - Updated Dockerfile to install necessary packages and set up user permissions. - Modified package.json and package-lock.json to include `https-proxy-agent` dependency.
- Add automatic proxy detection using standard environment variables - Support HTTPS_PROXY, HTTP_PROXY, https_proxy, http_proxy - Move https-proxy-agent to optional dependencies - Enhance settings with proxy configuration while maintaining backward compatibility - Add comprehensive documentation and unit tests for proxy functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split Evaluator
What did you accomplish?
Added comprehensive HTTP/HTTPS proxy support to Split.io Evaluator, enabling deployment in corporate environments with network restrictions.
Key Features Implemented:
Technical Changes:
sdk.jswith proxy detection and configuration logicpackage.jsonto include https-proxy-agent as a dependencyHow do we test the changes introduced in this PR?
npm test tests/proxy.test.js
Extra Notes
This implementation resolves timeout issues when deploying Split.io Evaluator in corporate environments with proxy restrictions. Previously, the evaluator could not connect to Split.io APIs (sdk.split.io, auth.split.io, events.split.io) due to network restrictions.
Implementation Approach: