Skip to content

Commit c838083

Browse files
committed
update test
1 parent 6f2d224 commit c838083

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

tests/client/test_client.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2874,7 +2874,6 @@ async def synchronize_config(*_):
28742874
pass
28752875

28762876
@pytest.mark.asyncio
2877-
@mock.patch('splitio.engine.evaluator.Evaluator.eval_with_context', side_effect=RuntimeError())
28782877
async def test_fallback_treatment_eval_exception(self, mocker):
28792878
# using fallback when the evaluator has RuntimeError exception
28802879
split_storage = mocker.Mock(spec=SplitStorage)
@@ -2891,7 +2890,7 @@ async def test_fallback_treatment_eval_exception(self, mocker):
28912890
telemetry_storage = await InMemoryTelemetryStorageAsync.create()
28922891
telemetry_producer = TelemetryStorageProducerAsync(telemetry_storage)
28932892
telemetry_evaluation_producer = telemetry_producer.get_telemetry_evaluation_producer()
2894-
impmanager = ImpressionManager(StrategyOptimizedMode(), StrategyNoneMode(), telemetry_producer.get_telemetry_runtime_producer())
2893+
impmanager = ImpressionManager(StrategyDebugMode(), StrategyNoneMode(), telemetry_producer.get_telemetry_runtime_producer())
28952894
recorder = StandardRecorderAsync(impmanager, event_storage, impression_storage, telemetry_evaluation_producer, telemetry_producer.get_telemetry_runtime_producer())
28962895

28972896
class TelemetrySubmitterMock():
@@ -2924,6 +2923,10 @@ async def put(impressions):
29242923

29252924
client = ClientAsync(factory, recorder, True, FallbackTreatmentCalculator(FallbackTreatmentsConfiguration(FallbackTreatment("on-global", '{"prop": "val"}'))))
29262925

2926+
def eval_with_context(*_):
2927+
raise RuntimeError()
2928+
client._evaluator.eval_with_context = eval_with_context
2929+
29272930
async def get_feature_flag_names_by_flag_sets(*_):
29282931
return ["some", "some2"]
29292932
client._get_feature_flag_names_by_flag_sets = get_feature_flag_names_by_flag_sets
@@ -3027,7 +3030,6 @@ async def fetch_many_rbs(*_):
30273030
pass
30283031

30293032
@pytest.mark.asyncio
3030-
@mock.patch('splitio.engine.evaluator.Evaluator.eval_with_context', side_effect=Exception())
30313033
async def test_fallback_treatment_exception(self, mocker):
30323034
# using fallback when the evaluator has RuntimeError exception
30333035
split_storage = mocker.Mock(spec=SplitStorage)
@@ -3043,7 +3045,7 @@ async def test_fallback_treatment_exception(self, mocker):
30433045

30443046
telemetry_storage = await InMemoryTelemetryStorageAsync.create()
30453047
telemetry_producer = TelemetryStorageProducerAsync(telemetry_storage)
3046-
impmanager = ImpressionManager(StrategyOptimizedMode(), StrategyNoneMode(), telemetry_producer.get_telemetry_runtime_producer())
3048+
impmanager = ImpressionManager(StrategyDebugMode(), StrategyNoneMode(), telemetry_producer.get_telemetry_runtime_producer())
30473049
recorder = StandardRecorderAsync(impmanager, event_storage, impression_storage, telemetry_producer.get_telemetry_evaluation_producer(), telemetry_producer.get_telemetry_runtime_producer())
30483050

30493051
factory = SplitFactoryAsync(mocker.Mock(),
@@ -3075,6 +3077,10 @@ def synchronize_config(*_):
30753077
factory._telemetry_submitter = TelemetrySubmitterMock()
30763078

30773079
client = ClientAsync(factory, recorder, True, FallbackTreatmentCalculator(FallbackTreatmentsConfiguration(FallbackTreatment("on-global"))))
3080+
3081+
def eval_with_context(*_):
3082+
raise Exception()
3083+
client._evaluator.eval_with_context = eval_with_context
30783084

30793085
async def context_for(*_):
30803086
return EvaluationContext(

0 commit comments

Comments
 (0)