fix tests

Author: chillaq

CHANGES.txt

@@ -1,6 +1,7 @@
 10.5.0 (Sep 12, 2025)
 - Changed the log level from error to debug when renewing the token for Streaming service in asyncio mode.
 - Added new configuration for Fallback Treatments, which allows setting a treatment value and optional config to be returned in place of "control", either globally or by flag. Read more in our docs.
+- Deprecated config parameter `redisErrors` as it is removed in redis lib since 6.0.0 version (https://github.com/redis/redis-py/releases/tag/v6.0.0).
 
 10.4.0 (Aug 4, 2025)
 - Added a new optional argument to the client `getTreatment` methods to allow passing additional evaluation options, such as a map of properties to append to the generated impressions sent to Split backend. Read more in our docs.

tests/client/test_factory.py

@@ -27,32 +27,37 @@
 class SplitFactoryTests(object):
     """Split factory test cases."""
 
-    def test_flag_sets_counts(self):
+    def test_flag_sets_counts(self):        
         factory = get_factory("none", config={
             'flagSetsFilter': ['set1', 'set2', 'set3']
         })
 
         assert factory._telemetry_init_producer._telemetry_storage._tel_config._flag_sets == 3
         assert factory._telemetry_init_producer._telemetry_storage._tel_config._flag_sets_invalid == 0
-        factory.destroy()
-
+        event = threading.Event()
+        factory.destroy(event)
+        event.wait()
+        
         factory = get_factory("none", config={
             'flagSetsFilter': ['s#et1', 'set2', 'set3']
         })
         assert factory._telemetry_init_producer._telemetry_storage._tel_config._flag_sets == 3
         assert factory._telemetry_init_producer._telemetry_storage._tel_config._flag_sets_invalid == 1
-        factory.destroy()
+        event = threading.Event()
+        factory.destroy(event)
+        event.wait()
 
         factory = get_factory("none", config={
             'flagSetsFilter': ['s#et1', 22, 'set3']
         })
         assert factory._telemetry_init_producer._telemetry_storage._tel_config._flag_sets == 3
         assert factory._telemetry_init_producer._telemetry_storage._tel_config._flag_sets_invalid == 2
-        factory.destroy()
+        event = threading.Event()
+        factory.destroy(event)
+        event.wait()
 
     def test_inmemory_client_creation_streaming_false(self, mocker):
         """Test that a client with in-memory storage is created correctly."""
-
         # Setup synchronizer
         def _split_synchronizer(self, ready_flag, some, auth_api, streaming_enabled, sdk_matadata, telemetry_runtime_producer, sse_url=None, client_key=None):
             synchronizer = mocker.Mock(spec=Synchronizer)
@@ -518,9 +523,15 @@ def synchronize_config(*_):
         event.wait()
         assert _INSTANTIATED_FACTORIES['some_other_api_key'] == 1
         assert _INSTANTIATED_FACTORIES['some_api_key'] == 2
-        factory2.destroy()
-        factory3.destroy()
-        factory4.destroy()
+        event = threading.Event()
+        factory2.destroy(event)
+        event.wait()
+        event = threading.Event()
+        factory3.destroy(event)
+        event.wait()
+        event = threading.Event()
+        factory4.destroy(event)
+        event.wait()
 
     def test_uwsgi_preforked(self, mocker):
         """Test preforked initializations."""
@@ -740,47 +751,53 @@ async def test_flag_sets_counts(self):
     @pytest.mark.asyncio
     async def test_inmemory_client_creation_streaming_false_async(self, mocker):
         """Test that a client with in-memory storage is created correctly for async."""
-
         # Setup synchronizer
         def _split_synchronizer(self, ready_flag, some, auth_api, streaming_enabled, sdk_matadata, telemetry_runtime_producer, sse_url=None, client_key=None):
             synchronizer = mocker.Mock(spec=SynchronizerAsync)
             async def sync_all(*_):
                 return None
             synchronizer.sync_all = sync_all
+
+            def start_periodic_fetching():
+                pass        
+            synchronizer.start_periodic_fetching = start_periodic_fetching
+
             self._ready_flag = ready_flag
             self._synchronizer = synchronizer
             self._streaming_enabled = False
             self._telemetry_runtime_producer = telemetry_runtime_producer
+            
         mocker.patch('splitio.sync.manager.ManagerAsync.__init__', new=_split_synchronizer)
 
         async def synchronize_config(*_):
             pass
         mocker.patch('splitio.sync.telemetry.InMemoryTelemetrySubmitterAsync.synchronize_config', new=synchronize_config)
 
         # Start factory and make assertions
-        factory = await get_factory_async('some_api_key', config={'streamingEmabled': False})
-        assert isinstance(factory, SplitFactoryAsync)
-        assert isinstance(factory._storages['splits'], inmemmory.InMemorySplitStorageAsync)
-        assert isinstance(factory._storages['segments'], inmemmory.InMemorySegmentStorageAsync)
-        assert isinstance(factory._storages['impressions'], inmemmory.InMemoryImpressionStorageAsync)
-        assert factory._storages['impressions']._impressions.maxsize == 10000
-        assert isinstance(factory._storages['events'], inmemmory.InMemoryEventStorageAsync)
-        assert factory._storages['events']._events.maxsize == 10000
+        factory2 = await get_factory_async('some_api_key', config={'streamingEmabled': False})
 
-        assert isinstance(factory._sync_manager, ManagerAsync)
+        assert isinstance(factory2, SplitFactoryAsync)
+        assert isinstance(factory2._storages['splits'], inmemmory.InMemorySplitStorageAsync)
+        assert isinstance(factory2._storages['segments'], inmemmory.InMemorySegmentStorageAsync)
+        assert isinstance(factory2._storages['impressions'], inmemmory.InMemoryImpressionStorageAsync)
+        assert factory2._storages['impressions']._impressions.maxsize == 10000
+        assert isinstance(factory2._storages['events'], inmemmory.InMemoryEventStorageAsync)
+        assert factory2._storages['events']._events.maxsize == 10000
 
-        assert isinstance(factory._recorder, StandardRecorderAsync)
-        assert isinstance(factory._recorder._impressions_manager, ImpressionsManager)
-        assert isinstance(factory._recorder._event_sotrage, inmemmory.EventStorage)
-        assert isinstance(factory._recorder._impression_storage, inmemmory.ImpressionStorage)
+        assert isinstance(factory2._sync_manager, ManagerAsync)
 
-        assert factory._labels_enabled is True
+        assert isinstance(factory2._recorder, StandardRecorderAsync)
+        assert isinstance(factory2._recorder._impressions_manager, ImpressionsManager)
+        assert isinstance(factory2._recorder._event_sotrage, inmemmory.EventStorage)
+        assert isinstance(factory2._recorder._impression_storage, inmemmory.ImpressionStorage)
+
+        assert factory2._labels_enabled is True
         try:
-            await factory.block_until_ready(1)
+            await factory2.block_until_ready(1)
         except:
             pass
-        assert factory.ready
-        await factory.destroy()
+        assert factory2._status == Status.READY
+        await factory2.destroy()
 
     @pytest.mark.asyncio
     async def test_destroy_async(self, mocker):
@@ -884,7 +901,7 @@ async def start(*_):
             await factory.block_until_ready(1)
         except:
             pass
-        assert factory.ready
+        assert factory._status == Status.READY
         assert factory.destroyed is False
 
         await factory.destroy()
@@ -925,7 +942,7 @@ async def test_pluggable_client_creation_async(self, mocker):
             await factory.block_until_ready(1)
         except:
             pass
-        assert factory.ready
+        assert factory._status == Status.READY
         await factory.destroy()
 
     @pytest.mark.asyncio
@@ -954,3 +971,4 @@ async def _make_factory_with_apikey(apikey, *_, **__):
         await asyncio.sleep(0.5)
         assert factory.destroyed
         assert len(build_redis.mock_calls) == 2
+        

tests/client/test_input_validator.py

@@ -1705,7 +1705,8 @@ async def get_change_number(*_):
             impmanager,
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         ready_mock = mocker.PropertyMock()
         ready_mock.return_value = True
@@ -1967,7 +1968,8 @@ async def get_change_number(*_):
             impmanager,
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         ready_mock = mocker.PropertyMock()
         ready_mock.return_value = True
@@ -2211,7 +2213,8 @@ async def put(*_):
             impmanager,
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         factory._sdk_key = 'some-test'
 
@@ -2501,7 +2504,8 @@ async def fetch_many_rbs(*_):
             impmanager,
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         ready_mock = mocker.PropertyMock()
         ready_mock.return_value = True
@@ -2665,7 +2669,8 @@ async def fetch_many_rbs(*_):
             impmanager,
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         split_mock.name = 'some_feature'
 
@@ -2832,7 +2837,8 @@ async def fetch_many_rbs(*_):
             mocker.Mock(),
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         ready_mock = mocker.PropertyMock()
         ready_mock.return_value = True
@@ -2978,7 +2984,8 @@ async def get_feature_flags_by_sets(*_):
             mocker.Mock(),
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         ready_mock = mocker.PropertyMock()
         ready_mock.return_value = True
@@ -3133,7 +3140,8 @@ async def get_feature_flags_by_sets(*_):
             mocker.Mock(),
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         ready_mock = mocker.PropertyMock()
         ready_mock.return_value = True
@@ -3282,7 +3290,8 @@ async def get_feature_flags_by_sets(*_):
             mocker.Mock(),
             telemetry_producer,
             telemetry_producer.get_telemetry_init_producer(),
-            mocker.Mock()
+            mocker.Mock(),
+            None
         )
         ready_mock = mocker.PropertyMock()
         ready_mock.return_value = True