Skip to content

Large Segments tests: polling mode #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2024
Merged

Large Segments tests: polling mode #814

merged 3 commits into from
Jul 25, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Jul 24, 2024 •
edited
Loading

JS SDK

What did you accomplish?

  • Fix some typos and rename fallbacking by fallback.
  • Update push-fallback tests to validate that myLargeSegments are fetched with polling when streaming mode switches to polling mode.

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner July 24, 2024 02:17
javrudsky
javrudsky approved these changes Jul 25, 2024
View reviewed changes
Copy link

@javrudsky javrudsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EmilianoSanchez EmilianoSanchez merged commit 5a37cb7 into SDKS-8407_integration Jul 25, 2024
3 checks passed
@EmilianoSanchez EmilianoSanchez deleted the SDK-8407_e2e_tests_polling branch July 25, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javrudsky javrudsky javrudsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @javrudsky