Define consistent float ordering #808
Conversation
|
The downside though is that sorting an array of floats won't give what users probably expect? |
|
I don’t think anyone has expectation how nans sort. There’s no way to sort arbitrary float arrays without this |
|
Right, but the bit wise ordering of non-NaN floats isn't the same as the natural ordering? |
|
Hm, you're right. I think I went too far. You can define equality using bit equality |
robert3005
force-pushed
the
rk/nanordering
branch
from
509aa2f to
9f5567f
Compare
robert3005
changed the title
| fn compare(self, other: Self) -> Ordering; | ||
|
|
||
| fn is_eq(self, other: Self) -> bool; |
There was a problem hiding this comment.
Can't these two be expressed with additional trait bounds?
There was a problem hiding this comment.
We can define an additional traits but afaik there isn't one that has the behaviour as implemented here
There was a problem hiding this comment.
ok I got it, its about the custom implementation
robert3005
force-pushed
the
rk/nanordering
branch
from
d899473 to
6bed4fb
Compare
| @@ -30,7 +31,6 @@ pub enum PType { | |||
| pub trait NativePType: | |||
| Send | |||
| + Sync | |||
| + Sized | |||
There was a problem hiding this comment.
Because it's always Sized https://doc.rust-lang.org/std/marker/trait.Sized.html
We use total_cmp instead of partial_cmp to compare floating point numbers and use bit patern to determine float equality