Add scalar_at_unchecked
#666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
reviewed
Aug 21, 2024
| } else { | ||
| return Ok(Scalar::null(self.dtype().clone())); | ||
| } | ||
| Ok(self.scalar_at_unchecked(index)) |
There was a problem hiding this comment.
will this still return Scalar::null?
There was a problem hiding this comment.
The top-level function will do that check, if someone tries to access a logically null value they will probably get 0 but its undefined territory IMO
AdamGS
force-pushed
the
adamg/unchecked-scalar
branch
from
1469c0a to
35e4517
Compare
robert3005
reviewed
Aug 21, 2024
robert3005
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves two pieces of future work:
Scalarwrapper.