-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scalar_at_unchecked
#666
Conversation
} else { | ||
return Ok(Scalar::null(self.dtype().clone())); | ||
} | ||
Ok(self.scalar_at_unchecked(index)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this still return Scalar::null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The top-level function will do that check, if someone tries to access a logically null value they will probably get 0
but its undefined territory IMO
1469c0a
to
35e4517
Compare
This PR serves two pieces of future work:
Scalar
wrapper.