Fix RunEndArray filter #1380
Merged
Fix RunEndArray filter #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
commented
Nov 20, 2024
| @@ -160,6 +160,8 @@ impl FilterFn for RunEndArray { | |||
| // Code adapted from apache arrow-rs https://github.com/apache/arrow-rs/blob/b1f5c250ebb6c1252b4e7c51d15b8e77f4c361fa/arrow-select/src/filter.rs#L425 | |||
| fn filter_run_ends<R: NativePType + AddAssign + From<bool> + AsPrimitive<u64>>( | |||
| run_ends: &[R], | |||
There was a problem hiding this comment.
I tried converting this to impl Iterator<Item = usize> but still need to pass the length and would needlesly widen type of the ends.
There was a problem hiding this comment.
You can do impl Iterator + ExactSizeIterator
There was a problem hiding this comment.
Oooo, let me try that
lwwmanning
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1368