feat: cache FilterMask iterators #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
reviewed
Nov 18, 2024
robert3005
reviewed
Nov 18, 2024
robert3005
reviewed
Nov 18, 2024
lwwmanning
requested changes
Nov 18, 2024
lwwmanning
reviewed
Nov 18, 2024
lwwmanning
changed the title
lwwmanning
reviewed
Nov 18, 2024
| @@ -10,47 +10,60 @@ impl FilterFn for BoolArray { | |||
| let validity = self.validity().filter(&mask)?; | |||
|
|
|||
| let buffer = match mask.iter()? { | |||
| FilterIter::Indices(iter) => { | |||
| filter_indices(self.boolean_buffer(), mask.true_count(), iter) | |||
| FilterIter::Indices(indices) => filter_indices_slice(&self.boolean_buffer(), indices), | |||
There was a problem hiding this comment.
calling filter_indices_slice for the indices branch looks... incorrect?
There was a problem hiding this comment.
or, maybe correct but just confusing name
lwwmanning
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a cute trick to pre-cache filter indices when a FilterMask is cloned. Unfortunately... we have to clone one every time we pass it into with_dyn!!