-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: it's a bird, it's a plane, it's vortex-all! #1140
Conversation
One crate to rule them all and in the darkness bind them.
vortex-rs/Cargo.toml
Outdated
@@ -0,0 +1,42 @@ | |||
[package] | |||
name = "vortex-rs" | |||
description = "Vortex with all builtin codecs and a sampling compressor." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this crate to re-export all the underlying dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also move a bunch of the docs in vortex-array
here, but that can be a separate PR
and probably with some module structure, the same way |
I did this:
|
You can see what it looks like in bench-vortex and pyvortex now. |
I think we liked |
Auto merge disabled until #1124 merges. |
@robert3005 Do you have more mega PRs to land? |
None that you need to block on |
One crate to rule them all and in the darkness bind them.