Skip to content

docs(*): update README.md; add example; use manifest v2#45

Merged
vdice merged 3 commits into
spinframework:mainfrom
vdice:docs/readme-example-updates
Nov 3, 2023
Merged

docs(*): update README.md; add example; use manifest v2#45
vdice merged 3 commits into
spinframework:mainfrom
vdice:docs/readme-example-updates

Conversation

@vdice
Copy link
Copy Markdown
Contributor

@vdice vdice commented Nov 2, 2023

  • Updates the README.md
  • Migrates spin.toml, snippets, etc to manifest v2
  • Adds a "rust-classic" rust-standalone example (better name?)

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice requested review from dicej and itowlson November 2, 2023 21:27
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread examples/rust-classic/README.md Outdated
Comment thread examples/rust-classic/Cargo.toml Outdated
Comment thread examples/rust-classic/Cargo.toml Outdated
Copy link
Copy Markdown
Contributor

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would maybe mention that Spin 2.0 (or some other runtime that supports wasi:http@0.2.0-rc-2023-10-18, such as wasmtime serve or NGNIX Unit) is required not just to try the examples but to use this component in any meaningful way.

Comment thread README.md Outdated
@vdice
Copy link
Copy Markdown
Contributor Author

vdice commented Nov 2, 2023

Addressed feedback in 07784a9. Also added a section mentioning its use via the corresponding spin template.

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice force-pushed the docs/readme-example-updates branch from 2b7da52 to 07784a9 Compare November 2, 2023 22:20
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice merged commit f72b433 into spinframework:main Nov 3, 2023
@vdice vdice deleted the docs/readme-example-updates branch November 3, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants