update SDK, use wasi-http streaming, etc.#43
Merged
Conversation
The main change is to support streaming so we don't need to buffer each file entirely into memory. This required a bit of refactoring. This also adds `deflate` and `gzip` encoding support since it was easy. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
radu-matei
approved these changes
Oct 30, 2023
Member
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
This looks great, manually tested this with a few static-asset-heavy applications and everything LGTM.
Also tested the composition example, which is a great addition!
Thanks!
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change is to support streaming so we don't need to buffer each file entirely into memory. This required a bit of refactoring. This also adds
deflateandgzipencoding support since it was easy.I've also added an
examplesdirectory to illustrate how to compose the server with applications. Currently, there's just one Rust example, but I'm planning to add more for other languages.We should probably delay merging this until Spin 2.0 is released, since it requires stable component support.