Change Cache-Control default max-age to one minute#20
Merged
Conversation
Contributor
Author
|
@technosophos FYI |
lann
force-pushed
the
shorter-default-max-age
branch
from
8e02d87 to
7ba1cc9
Compare
Contributor
|
Should this be a configuration in spin.toml? |
Contributor
Author
|
It is. Hence "default" 🙂 |
Contributor
|
👯♂️ - It's Friday!!! (trying to come up with an excuse...) |
The extremely long cache expiration doesn't match usage. Also clean up a minor clippy lint. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
shorter-default-max-age
branch
from
7ba1cc9 to
c17750e
Compare
mikkelhegn
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extremely long cache expiration doesn't match usage.
Also clean up a minor clippy lint.