Optionally prefer downstream X509 CA TTL #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plumbs through and uses the "preferred TTL" value from the downstream server when minting downstream X509 CA. This behavior is still off by default. It can be turned on by setting the `use_legacy_downstream_x509_ca_ttl=false` configuration value. This configuration value will remain false by default through SPIRE v1.11.xx. The default can change to true, and the flag deprecated, in SPIRE v1.12.0. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
MarcosDY
reviewed
Jul 5, 2024
Signed-off-by: Andrew Harding <azdagron@gmail.com>
MarcosDY
approved these changes
Jul 8, 2024
edwbuck
pushed a commit
to edwbuck/spire
that referenced
this pull request
Aug 20, 2024
Plumbs through and uses the "preferred TTL" value from the downstream server when minting downstream X509 CA. This behavior is still off by default. It can be turned on by setting the `use_legacy_downstream_x509_ca_ttl=false` configuration value. This configuration value will remain false by default through SPIRE v1.11.xx. The default can change to true, and the flag deprecated, in SPIRE v1.12.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumbs through and uses the "preferred TTL" value from the downstream server when minting downstream X509 CA.
This behavior is still off by default. It can be turned on by setting the
use_legacy_downstream_x509_ca_ttl=falseconfiguration value.This configuration value will remain false by default through SPIRE v1.11.xx. The default can change to true, and the flag deprecated, in SPIRE v1.12.0.
Resolves #5236