Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up PSAT audience validation #5142

Merged
merged 2 commits into from
May 14, 2024

Conversation

azdagron
Copy link
Member

Kubernetes docs advise that callers of the TokenReview API should cross check the audience fields in the spec and status just in case there is a validator out there that is audience-unaware.

Kubernetes docs advise that callers of the TokenReview API should cross
check the audience fields in the spec and status just in case there is
a validator out there that is audience-unaware.

Signed-off-by: Andrew Harding <azdagron@gmail.com>
@azdagron azdagron added this to the 1.10.0 milestone May 13, 2024
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@azdagron azdagron merged commit 3b3c099 into spiffe:main May 14, 2024
33 checks passed
@azdagron azdagron deleted the double-check-token-review-audience branch May 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants