Chore/aws partition support #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achaurasiaConfluent
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
achaurasiaConfluent
force-pushed
the
chore/aws-parition-support
branch
from
5d79df6
to
7686103
Compare
rturner3
reviewed
Aug 15, 2023
achaurasiaConfluent
force-pushed
the
chore/aws-parition-support
branch
2 times, most recently
from
f48d671
to
4cf0898
Compare
rturner3
reviewed
Aug 21, 2023
There was a problem hiding this comment.
It looks like some unintended commits from main got included into the branch associated with this PR. Could you clean this up to only include the commits you are proposing using git rebase -i main followed by a git push -f <remote> achaurasiaConfluent:chore/aws-parition-support?
achaurasiaConfluent
force-pushed
the
chore/aws-parition-support
branch
from
8e0cb7e
to
c928cd1
Compare
Signed-off-by: Anil Chaurasia <achaurasia@confluent.io>
Signed-off-by: Anil Chaurasia <achaurasia@confluent.io>
Signed-off-by: Anil Chaurasia <achaurasia@confluent.io>
Signed-off-by: Anil Chaurasia <achaurasia@confluent.io>
achaurasiaConfluent
force-pushed
the
chore/aws-parition-support
branch
from
c928cd1
to
75717a7
Compare
Signed-off-by: Anil Chaurasia <achaurasia@confluent.io>
Signed-off-by: Anil Chaurasia <achaurasia@confluent.io>
achaurasiaConfluent
force-pushed
the
chore/aws-parition-support
branch
from
75717a7
to
a0078a0
Compare
achaurasiaConfluent
force-pushed
the
chore/aws-parition-support
branch
from
a936ef8
to
fc8faf3
Compare
Signed-off-by: Anil Chaurasia <achaurasia@confluent.io>
rturner3
previously approved these changes
Aug 24, 2023
|
|
||
| t.Run("success when valid partitions specified ", func(t *testing.T) { | ||
| for _, partition := range partitions { | ||
| err := doConfig(t, coreConfig, fmt.Sprintf("partition = \"%s\"", partition)) |
There was a problem hiding this comment.
Suggested change
| err := doConfig(t, coreConfig, fmt.Sprintf("partition = \"%s\"", partition)) | |
| err := doConfig(t, coreConfig, fmt.Sprintf("partition = %q", partition)) |
nit: one small simplification
There was a problem hiding this comment.
thank you. Updated.
| // No constant was found in the sdk, using the list of paritions defined on | ||
| // the page https://docs.aws.amazon.com/IAM/latest/UserGuide/reference-arns.html | ||
| partitions = []string{ | ||
| "aws", |
There was a problem hiding this comment.
Suggested change
| "aws", | |
| defaultPartition, |
There was a problem hiding this comment.
Updated.
Signed-off-by: Anil Chaurasia <achaurasia@confluent.io>
azdagron
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
SPIRE Server AWSIID node attestor
Description of change
Currently spire node attestation only works in default aws partition. This PR allow server to attest nodes in non default partition.
Note that server can not cross partition boundary.
Which issue this PR fixes
#4423
Signed-off-by: achaurasia@confluent.io