[SPIRE Agent] add telemetry around LRU cache entry operations #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugordon7
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Signed-off-by: gordonhu7 <hu.gordon@hotmail.com>
hugordon7
force-pushed
the
gordonhu-add-agent-lru-cache-telemetry
branch
from
9681c60 to
2270bc9
Compare
amoore877
reviewed
Jul 11, 2023
Signed-off-by: gordonhu7 <hu.gordon@hotmail.com>
hugordon7
force-pushed
the
gordonhu-add-agent-lru-cache-telemetry
branch
from
2ec9ca8 to
ab32e25
Compare
amoore877
reviewed
Jul 12, 2023
amoore877
reviewed
Jul 12, 2023
Signed-off-by: gordonhu7 <hu.gordon@hotmail.com>
hugordon7
force-pushed
the
gordonhu-add-agent-lru-cache-telemetry
branch
from
6b2556f to
1a7e20c
Compare
Signed-off-by: gordonhu7 <hu.gordon@hotmail.com>
hugordon7
force-pushed
the
gordonhu-add-agent-lru-cache-telemetry
branch
from
d02d89e to
3dc6d1a
Compare
Signed-off-by: gordonhu7 <hu.gordon@hotmail.com>
Signed-off-by: gordonhu7 <hu.gordon@hotmail.com>
amoore877
reviewed
Jul 13, 2023
amoore877
reviewed
Jul 13, 2023
amoore877
reviewed
Jul 13, 2023
amoore877
reviewed
Jul 13, 2023
|
I think that's the last of my comments. Eager to see what the maintainers and rest of the community think :) |
evan2645
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Thanks for the contribution @hugordon7 and for the review @amoore877!
|
@hugordon7 we need a DCO on the commit in order to merge it. You can read more about DCO here, you can use |
hugordon7
force-pushed
the
gordonhu-add-agent-lru-cache-telemetry
branch
3 times, most recently
from
1b81e7e to
c5de92a
Compare
Signed-off-by: gordonhu7 <hu.gordon@hotmail.com>
hugordon7
force-pushed
the
gordonhu-add-agent-lru-cache-telemetry
branch
from
c5de92a to
6d8851b
Compare
Neniel
pushed a commit
to Neniel/spire
that referenced
this pull request
Jul 21, 2023
…#4335) * [SPIRE Agent] add telemetry around LRU cache entry operations Signed-off-by: gordonhu7 <hu.gordon@hotmail.com> Co-authored-by: gordonhu7 <hu.gordon@hotmail.com> Co-authored-by: Evan Gilman <evan@spirl.com> Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
Neniel
pushed a commit
to Neniel/spire
that referenced
this pull request
Aug 24, 2023
…#4335) * [SPIRE Agent] add telemetry around LRU cache entry operations Signed-off-by: gordonhu7 <hu.gordon@hotmail.com> Co-authored-by: gordonhu7 <hu.gordon@hotmail.com> Co-authored-by: Evan Gilman <evan@spirl.com> Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected functionality
Adds metrics around LRU cache entry operations. On every LRU cache entry add, update, and removal, a counter is incremented. After each call to update entries and SVIDs, the total size of the entry and SVID map is reported.
Also renames the ExpiresAt field to SVIDExpiresAt in the StaleEntries struct and adds an additional log field entry_id to a log.
Description of change
Additional observability into LRU cache entry operations and memory usage.
Which issue this PR fixes
N/A