Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SPIRE to issue wildcard certificate #4793

Closed
cb-troydai opened this issue Jan 12, 2024 · 3 comments · Fixed by #4814
Closed

Allow SPIRE to issue wildcard certificate #4793

cb-troydai opened this issue Jan 12, 2024 · 3 comments · Fixed by #4814
Assignees
Labels
priority/backlog Issue is approved and in the backlog

Comments

@cb-troydai
Copy link

  • Version:

Future SPIRE, preferable back-port to supported minor versions.

  • Platform:

All supported platforms

  • Subsystem:

Server

Brief

The SPIRE server rejects any attempt to creating a service entry with a DNS contains wildcard. Therefore it doesn't issue wildcard certificate. Understand that this issue has been raided in #1809. And @evan2645 addressed in this comment: #1809 (comment)

I'd like to provide a case of the usage of wildcard certificate.

Case

I'm using SPIFFE/SPIRE as the workload identity provider for Istio. SPIRE infrastructure issue the SVID for both workloads' proxies as well as ingress gateway, which itself is a istio-proxy (envoy).

Once ingress gateway's SDS is configured to the spire-agent, I'm able to issue key materials for TLS termination (as well as mTLS). However, the certificate is limited to support the host names that are defined in the DNS fields (SAN). I haven't tested the max supported amount of SANs, but I believe there is a limitation to it.

A wildcard certificate makes it easier to support this scenario. This allows us to:

  1. Support host based routing;
  2. Issue all key material from spire-agent without using kubernetes secret, which is inherently insecure.
@azdagron azdagron added triage/in-progress Issue triage is in progress priority/backlog Issue is approved and in the backlog and removed triage/in-progress Issue triage is in progress labels Jan 16, 2024
@azdagron
Copy link
Member

We've discussed this and feel it is reasonable.

@aaomidi
Copy link
Contributor

aaomidi commented Jan 16, 2024

Happy to take this on

@azdagron
Copy link
Member

Awesome, thanks @aaomidi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants