Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT signing key validity period not considered in calculation of bundle "spiffe_refresh_hint" #2256

Open
rturner3 opened this issue May 6, 2021 · 3 comments
Open

JWT signing key validity period not considered in calculation of bundle "spiffe_refresh_hint" #2256

rturner3 opened this issue May 6, 2021 · 3 comments
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@rturner3
Copy link
Collaborator

rturner3 commented May 6, 2021

  • Version: 73f660b
  • Platform: All
  • Subsystem: Server

The spiffe_refresh_hint parameter of a bundle represents a suggestion for when a consumer should consider requesting a new version of the bundle, see SPIFFE Trust Domain and Bundle Section 4.1.2.

SPIRE currently only considers the lifetime of X.509 root CAs in the trust bundle for its calculation of this refresh hint. Today, SPIRE Server X.509 root CA and JWT signing keys have the same validity period, but ideally the refresh hint calculation should not depend on this assumption.
@rturner3 rturner3 changed the title JWT issuer key validity period not considered in calculation of bundle "spiffe_refresh_hint" JWT signing key validity period not considered in calculation of bundle "spiffe_refresh_hint" May 6, 2021
@azdagron azdagron added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Nov 4, 2022
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

This issue is stale because it has been open for 365 days with no activity.

@github-actions github-actions bot added the stale label Nov 4, 2023
@rturner3
Copy link
Collaborator Author

rturner3 commented Nov 6, 2023

This is still a valid issue.

@rturner3 rturner3 removed the stale label Nov 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

This issue is stale because it has been open for 365 days with no activity.

@github-actions github-actions bot added the stale label Nov 5, 2024
@MarcosDY MarcosDY removed the stale label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MarcosDY @azdagron @rturner3