TestMTLSWebHandshake/client_no_valid_certificate: Error message not equal

[jas4711]

Hi. I am packaging spiffe for Debian. We got self-test failures during build. Any ideas?

https://salsa.debian.org/jas/golang-github-spiffe-go-spiffe/-/jobs/5160566

=== RUN   TestMTLSWebHandshake/client_no_valid_certificate
    config_test.go:775: 
        	Error Trace:	/builds/jas/golang-github-spiffe-go-spiffe/debian/output/source_dir/_build/src/github.com/spiffe/go-spiffe/v2/spiffetls/tlsconfig/config_test.go:775
        	            				/builds/jas/golang-github-spiffe-go-spiffe/debian/output/source_dir/_build/src/github.com/spiffe/go-spiffe/v2/spiffetls/tlsconfig/config_test.go:727
        	Error:      	Error message not equal:
        	            	expected: "x509: certificate signed by unknown authority"
        	            	actual  : "tls: failed to verify certificate: x509: certificate signed by unknown authority"
        	Test:       	TestMTLSWebHandshake/client_no_valid_certificate
=== RUN   TestMTLSWebHandshake/unknown_authority
--- FAIL: TestMTLSWebHandshake (0.01s)
    --- PASS: TestMTLSWebHandshake/success (0.00s)
    --- PASS: TestMTLSWebHandshake/server_authentication_fails (0.00s)
    --- PASS: TestMTLSWebHandshake/server_handshake_fails (0.00s)
    --- FAIL: TestMTLSWebHandshake/client_no_valid_certificate (0.00s)
    --- PASS: TestMTLSWebHandshake/unknown_authority (0.00s)
FAIL
FAIL	github.com/spiffe/go-spiffe/v2/spiffetls/tlsconfig	0.039s
=== RUN   TestParseAndValidate

/Simon

[azdagron]

The unit tests are written against go1.19 but you're probably packaging with 1.20? 1.21? The error message changed unfortunately. The fix was merged today(see #252).

[azdagron]

I'll close this for now; please let me know if you need anything else!

[jas4711]

Thank you for quick response @azdagron! We are using go 1.21. I will add the patch to our builds and see how it goes, consider this fixed unless you hear anything.