Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sphinx as a required dependency #10

Merged
merged 4 commits into from
Jan 13, 2024

Conversation

phlax
Copy link
Contributor

@phlax phlax commented Aug 24, 2023

No description provided.

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@betaboon
Copy link

is there anything missing to get this in?
We're also running into this problem.

@phlax
Copy link
Contributor Author

phlax commented Oct 13, 2023

is there anything missing to get this in?

+1

@betaboon
Copy link

@AA-Turner friendly bump

@andy-maier
Copy link

Gentle reminder to get this in. We are also hampered by the circular dependency (using pipdeptree).

@phlax
Copy link
Contributor Author

phlax commented Nov 30, 2023

for bazel users it appears there is a workaround - see bazelbuild/rules_python#1586

struggling to understand why this fix was not just landed - a waste of my time - and tbh the workaround should not be necessary

@AA-Turner AA-Turner changed the title deps: Make Sphinx optional Remove Sphinx as a required dependency Jan 13, 2024
CHANGES Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
CHANGES Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@AA-Turner AA-Turner merged commit f0b7604 into sphinx-doc:master Jan 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants