Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringToSliceHookFunc adds TrimSpace to handle the problem of spaces before and after array strings #1665

Open
1 task done
whybangbang opened this issue Oct 20, 2023 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@whybangbang
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

  1. For example add this hook StringToSliceHookFunc(",") to viper, only handle this array string "a,b,c,d", can't handle "a, b, c, d", but in the same service, a viper will handle these two different formats
  2. https://github.com/urfave/cli have resolve this problem, refer to https://github.com/urfave/cli/blob/e8abd76fa3ee5f1bacb52eab9b71dedbeab41991/flag_slice_base.go#L61

Proposed Solution

Use TrimSpace trim items in string array, and also can trim other space defined by Unicode.

func StringToSliceHookFunc(sep string) mapstructure.DecodeHookFunc {
	return func(
		f reflect.Kind,
		t reflect.Kind,
		data interface{}) (interface{}, error) {
		if f != reflect.String || t != reflect.Slice {
			return data, nil
		}

		raw := data.(string)
		if raw == "" {
			return []string{}, nil
		}

		var strs []string
		for _, s := range strings.Split(raw, sep) {
			s = strings.TrimSpace(s)
			strs = append(strs, s)
		}

		return strs, nil
	}
}

Alternatives Considered

No response

Additional Information

No response

@whybangbang whybangbang added the kind/enhancement New feature or request label Oct 20, 2023
@github-actions
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant