remove unneeded error from printOption method #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marckhouzam
approved these changes
Dec 2, 2021
|
@jpmcb Hi John, do you mind taking a quick look at this PR? Should be a fairly straightforward fix :) Thanks! |
|
Can you add a description to this PR please? Thanks much!! |
|
@jpmcb Added. Thanks! |
|
This PR is being marked as stale due to a long period of inactivity |
|
we probably still want this - reopening and marking myself as reviewer |
hoshsadiq
pushed a commit
to zulucmd/zulu
that referenced
this pull request
Dec 31, 2022
The code below doesn't really need the `error` as return type, so I remove it
```go
func printOptions(buf *bytes.Buffer, cmd *cobra.Command, name string) error {
flags := cmd.NonInheritedFlags()
flags.SetOutput(buf)
if flags.HasAvailableFlags() {
parentFlags.PrintDefaults()
buf.WriteString("```\n\n")
}
return nil
}
```
Merge spf13/cobra#1549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code below doesn't really need the
erroras return type, so I remove it