Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arduino-cli to projects using cobra #1117

Merged
merged 2 commits into from
Sep 15, 2020
Merged

add arduino-cli to projects using cobra #1117

merged 2 commits into from
Sep 15, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented May 19, 2020

arduino-cli has been using cobra for almost a year.
I'm also working in adding shell completion using the latest features of cobra 1.0.0

@CLAassistant
Copy link

CLAassistant commented May 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@marckhouzam
Copy link
Collaborator

marckhouzam commented May 20, 2020 •
edited
Loading

I'm also working in adding shell completion using the latest features of cobra 1.0.0

Cool. I notice you had to replace the - by a _ for fish after generating completions. @umbynos would you mind opening an issue for Cobra to explain the problem? I think we should fix this directly in Cobra. You are also welcomed to provide a PR if you wish.

@umbynos umbynos mentioned this pull request May 20, 2020
Closed
@jharshman jharshman added the kind/documentation Documentation of cobra itself label May 29, 2020
@github-actions
Copy link

This PR is being marked as stale due to a long period of inactivity

marckhouzam
marckhouzam approved these changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maintainer but LGTM

@marckhouzam
Copy link
Collaborator

This is an easy merge @jpmcb

jpmcb
jpmcb approved these changes Sep 15, 2020
View reviewed changes
Copy link
Collaborator

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! And thanks mark for the heads up!! 🚀

@jpmcb jpmcb merged commit 6c06523 into spf13:master Sep 15, 2020
@silvanocerza
Copy link

Thank you very much! Really appreciated. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcb jpmcb jpmcb approved these changes

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees
No one assigned
Labels
kind/documentation Documentation of cobra itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@umbynos @CLAassistant @marckhouzam @silvanocerza @jpmcb @jharshman