rpc: handle passing wallet path as 'wallet' argument #10105
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handles passing the wallet path as 'wallet' argument instead of 'wallet_path'. This did work in 4.5.8 and fails in 4.6.0 as the wallet path string will get passed directly to the command instead of the required wallet object, causing an exception when methods are called on the str.
|
This was intentionally removed in 37914d5, perhaps due to misunderstanding why it was there. If we change it back, we need some kind of test that explicitly tests this behaviour, and explains we want it, otherwise we are just going back-and-forth :/ |
|
will undraft after implementing unittests based on the command testing framework mentioned in #9847 (comment) once its on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles passing the wallet path as
walletcommand argument instead ofwallet_path. This did work in 4.5.8 and fails in 4.6.0 as the wallet path string will get passed directly to the command instead of the required wallet object, causing an exception when methods are called on the str.Fixes #10097