Bug with southern hemisphere and DST

[StefanoMagrassi]

It seems that the DST "change" property it's not rightly handled in the southern hemisphere.

For example, if you set as date 2017-10-09 12:00 UTC and go to America/Sao_Paulo timezone, hour() method should return 09:00 because (ref):

• UTC standard offset is -3;
• UTC DST offset is -2;
• DST starts on october 15th

Coherently, if you change date to 2017-10-16 it should return as 10:00.

At this line the dst.change is constantly set to -60, but in the case above it should be +60.

Indeed, the timezone().offsets property returns {base: -240, dst: -180} instead of {base: -180, dst: -120}

Same happens with America/Campo_Grande and America/Cuiaba.

I can't understand if this pattern (inverse of current dst.change) could be applied to every timezone in the southern hemisphere.

Take a look to this repl

[spencermountain]

oh hey! duh! you're absolutely right.
man, thank you Stefano.
I should've caught this.
Will fix it pronto.
thanks!

[StefanoMagrassi]

You're welcome.

Please remember that I'm not 100% sure the pattern could be applied to every southern hemisphere timezone. Should be done further investigations

[spencermountain]

hey, have been busy. haven't forgot about this.
Hope to get it at the end of the week.

[spencermountain]

hey! i got this in v2.1.1.

you can see it here matching up with what it oughta be:

relevant tests
thanks!