Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Move management points out of the DAIKIN_CMD_SETS #86

Closed
jwillemsen opened this issue Feb 20, 2023 · 3 comments
Closed

Move management points out of the DAIKIN_CMD_SETS #86

jwillemsen opened this issue Feb 20, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@jwillemsen
Copy link
Collaborator

The code currently uses DAIKIN_CMD_SETS to define the possible command sets, but the fact that the management point (climateControlMainZone/gateway/domesticHotWaterTank) is cmd[0] results in a lot of code duplication, would be much easier overal when the getData/getValue calls pass the management point as first argument, that way for a lot of status flags we don't need accessors, now a lot of code is duplicated for the climate and for the hot water tank
@jwillemsen
Copy link
Collaborator Author

At the same moment we should rename the internal name of each entity to include the name of the management point, that way we can have for example a status flag for the climate and tank with the same field (fe error_code)

@jwillemsen jwillemsen added the enhancement New feature or request label Feb 23, 2023
This was referenced Mar 22, 2023
Closed
Closed
@jwillemsen jwillemsen mentioned this issue Jul 10, 2023
Closed
@jwillemsen jwillemsen mentioned this issue Oct 3, 2023
Open
jwillemsen referenced this issue in jwillemsen/daikin_onecta Oct 30, 2023
@jwillemsen
Updates to use the json as provided by Daikin, not do some preprocess…
aa75abe 
…ing on the data, see #86

    * custom_components/daikin_residential_altherma/device.py:
    * custom_components/daikin_residential_altherma/water_heater.py:
@jwillemsen jwillemsen mentioned this issue Oct 30, 2023
Closed
@jwillemsen
Copy link
Collaborator Author

#186 does update this for the water heater

@jwillemsen jwillemsen mentioned this issue Nov 23, 2023
Closed
@jwillemsen jwillemsen linked a pull request Dec 8, 2023 that will close this issue
Major refactoring and add support for Daikin AC units #205
Closed
@jwillemsen
Copy link
Collaborator Author

jwillemsen commented Dec 20, 2023 •
edited
Loading

Done, see https://github.com/jwillemsen/daikin_residential_altherma/releases/tag/v3.0.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major refactoring and add support for Daikin AC units jwillemsen/daikin_onecta
1 participant
@jwillemsen