Skip to content

Conversation

@magiino
Copy link
Contributor

@magiino magiino commented Apr 10, 2025

Feature #1718

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

I added a new optional parameter to CommandAppTester to override the default TestConsole.
The TestConsole can now be accessed through a public property of the CommandAppTester instance.
The new parameter is placed last to avoid introducing a breaking change.

Added tests and documentation on how to mock user inputs in interactive commands using CommandAppTester.

Please squash the commits when merging.


Please upvote 👍 this pull request if you are interested in it.

@magiino
Copy link
Contributor Author

magiino commented Apr 11, 2025

@magiino please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but left two small nitpick-comments that would be nice if you fixed. 👍

Co-authored-by: Patrik Svensson <patriksvensson@users.noreply.github.com>
@magiino
Copy link
Contributor Author

magiino commented Apr 14, 2025

Looks good to me, but left two small nitpick-comments that would be nice if you fixed. 👍

Thanks! I’ve applied the changes based on your comments. Let me know if there’s anything else! :)

@patriksvensson patriksvensson added this to the 0.51 milestone Apr 14, 2025
@patriksvensson patriksvensson merged commit 57dd8ee into spectreconsole:main Apr 14, 2025
3 checks passed
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants