-
Notifications
You must be signed in to change notification settings - Fork 144
as per request #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
as per request #160
Conversation
@tboggs, I have extensively tested it, and it works very well. |
Hi @tboggs, any update on this side? |
Hi @YannChemin, apologies for the delay. I'm away from my dev system for a few days. I'll review & test this by next week. |
The code looks good to me but before merging to master, please add some basic unit tests for creating and querying a Relab database. You should be able to copy most of the test code from one of the other databases in this file (you can also add the unit tests to the same file). |
This is done, test added |
@YannChemin Thanks for adding the unit tests. I will have time to test the code in the next day or two and merge into master. In the meantime, could you please rename the |
OK done @tboggs |
@YannChemin, I'm ready to look at this now. Are PR #158 and #160 identical, just merging to different branches? |
Loads Relab library basic info, does not load type, class and subclass
some code using ignorefiles is not needed