From 24032886781b34616fe59aafe162206cb902539e Mon Sep 17 00:00:00 2001 From: Dimitrie Stefanescu Date: Thu, 7 Nov 2024 17:46:37 +0000 Subject: [PATCH 1/2] fix: allows pre-transformation of all ITransformable objects --- .../Operations/Receive/RevitHostObjectBuilder.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs b/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs index ac740b667..6f487c994 100644 --- a/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs +++ b/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs @@ -183,7 +183,7 @@ CancellationToken cancellationToken // POC hack of the ages: try to pre transform curves before baking // we need to bypass the local to global converter as there we don't have access to what we want. that service will/should stop existing. if ( - localToGlobalMap.AtomicObject is ITransformable transformable and ICurve + localToGlobalMap.AtomicObject is ITransformable transformable // and ICurve && localToGlobalMap.Matrix.Count > 0 && localToGlobalMap.AtomicObject["units"] is string units ) From befb84db5fe607d400a48bf5fc957dfc3c0ca82b Mon Sep 17 00:00:00 2001 From: Dimitrie Stefanescu Date: Thu, 7 Nov 2024 17:46:53 +0000 Subject: [PATCH 2/2] chore: comments --- .../Operations/Receive/RevitHostObjectBuilder.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs b/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs index 6f487c994..6734d1219 100644 --- a/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs +++ b/Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs @@ -180,7 +180,7 @@ CancellationToken cancellationToken { using var activity = _activityFactory.Start("BakeObject"); - // POC hack of the ages: try to pre transform curves before baking + // POC hack of the ages: try to pre transform curves, points and meshes before baking // we need to bypass the local to global converter as there we don't have access to what we want. that service will/should stop existing. if ( localToGlobalMap.AtomicObject is ITransformable transformable // and ICurve