Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.20_Attribute types and geometry types aligned with arcgis_to_DEV #205

Merged

Conversation

KatKatKateryna
Copy link
Contributor

No description provided.

@KatKatKateryna KatKatKateryna marked this pull request as draft June 29, 2024 23:19
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 45.00000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 21.59%. Comparing base (110cd85) to head (f5c758a).
Report is 1 commits behind head on dev.

Files Patch % Lines
speckle/converter/layers/layer_conversions.py 10.34% 26 Missing ⚠️
speckle/converter/layers/GISLayerGeometryType.py 58.33% 10 Missing ⚠️
speckle/converter/layers/GISAttributeFieldType.py 70.37% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #205      +/-   ##
==========================================
+ Coverage   21.22%   21.59%   +0.36%     
==========================================
  Files          44       46       +2     
  Lines        6351     6405      +54     
==========================================
+ Hits         1348     1383      +35     
- Misses       5003     5022      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatKatKateryna KatKatKateryna marked this pull request as ready for review October 22, 2024 00:07
@KatKatKateryna KatKatKateryna merged commit bdc1398 into dev Oct 22, 2024
4 of 6 checks passed
@KatKatKateryna KatKatKateryna deleted the atrribute-types-and-geometry-types-aligned-with-ArcGIS branch October 22, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant