Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weblate tests fails in production after xml-editor merge #4458

Closed
grantfitzsimmons opened this issue Jan 23, 2024 · 3 comments · Fixed by #4513
Closed

Weblate tests fails in production after xml-editor merge #4458

grantfitzsimmons opened this issue Jan 23, 2024 · 3 comments · Fixed by #4513
Assignees
Labels
1 - Bug Incorrect behavior of the product
Milestone

Comments

@grantfitzsimmons
Copy link
Member

node:internal/process/esm_loader:40
      internalBinding('errors').triggerUncaughtException(
                                ^
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/runner/work/specify7/specify7/specifyweb/frontend/js_src/lib/components/DataModel/resourceApi' imported from /home/runner/work/specify7/specify7/specifyweb/frontend/js_src/lib/components/DataModel/saveBlockers.tsx

saveBlockers.tsx in production, saveBlockers.ts in v7.9.3-copy

image

We'll need to pick up on this and resolve it soon

@grantfitzsimmons grantfitzsimmons added the 1 - Bug Incorrect behavior of the product label Jan 23, 2024
@maxpatiiuk
Copy link
Member

This is a known bug in swc-node caused by node.js update
See swc-project/swc-node#743
They merged the fix PR 4 days ago - swc-project/swc-node#748
Now just to wait for them to release that

Hopefully that would be soon.
If we need solution either, we can either downgrade node.js to pre 20.6, or apply the fix manually locally

@CarolineDenis CarolineDenis added this to the 7.9.4 milestone Jan 25, 2024
@grantfitzsimmons
Copy link
Member Author

We'll downgrade on next Wednesday if nothing is fixed by then

@maxpatiiuk
Copy link
Member

Yes, either downgrade node, or migrate from swc to tsx (yes I know we just migrated from ts-node to swc. from my limited experience, ts-node is very powerful but hard to use, swc is powerful, and tsx is the simplest to use)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants