Skip to content

Fix #91 by passing all rdflib types in six.text_type function #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xavierfigueroav
Copy link
Collaborator

@xavierfigueroav xavierfigueroav commented Jun 12, 2019

  1. About fixing:
  • Pass all rdflib types in RDF parsers into six.text_type function before passing them into RDF builders.
  1. About tests:
  • Add test utilities that build a Python dictionary representation of the information stored in models.
  • Add a JSON file with expected info after parsing a test file.
  • Add tests that open a test file, open the expected file and compare them.

Signed-off-by: Xavier Figueroa xavierfigueroav@gmail.com

…passing them in builders methods.

Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
…ed file.

Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
@xavierfigueroav
Copy link
Collaborator Author

A test is currently failing due to the change in the license list version format. Waiting until #103 is merged.

@xavierfigueroav xavierfigueroav marked this pull request as ready for review August 18, 2019 01:00
pombredanne pushed a commit that referenced this pull request Aug 20, 2019
This is a following the merge of PR #110 for ticket #91

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne merged commit 4fb130a into spdx:master Aug 20, 2019
@pombredanne
Copy link
Member

Thanks!

@xavierfigueroav xavierfigueroav deleted the fix-rdflib-types-in-spdxmodels branch August 20, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants