Make some RouteRegistrar private methods and properties protected #165
MtDalPizzol
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I have a scenario where I need to tweak the way
RouteRegistrar.phpadds routes to the router. I thought of doing this by extending the class and overriding theregisterRoutesmethod, then binding my own RouteRegistrar to the container.The problem is that the original RouteRegistrar has some private properties and methods that are unreachable by my custom extending class:
laravel-route-attributes/src/RouteRegistrar.php
Line 23 in afaaf31
laravel-route-attributes/src/RouteRegistrar.php
Line 276 in afaaf31
Is it really necessary to have this
private? Couldn't they beprotectedinstead, allowing us to more easily customize it?Beta Was this translation helpful? Give feedback.
All reactions