Replies: 1 comment
-
|
Feel free to submit a PR. If the code is simple, well tested and documented, I'd consider pulling it in 👍 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Many of the routes packages create macros around the
\Illuminate\Routing\Routeclass. And even for implementing something for a specific project To improve compatibility with such situations, it would be good to have a "macros" param on theSpatie\RouteAttributes\Attributes\Route::__constructmethod (which, of course, implies having a $macros property.I though about the format (but I have to give it a little more thinking.):
Then, in the RouteRegistrar class (
laravel-route-attributes/src/RouteRegistrar.php
Line 172 in 1df42b6
If you see any problems with this, please let me know. If that's too priority for you guys, maybe I can implement this some point in the future and submit a PR.
Beta Was this translation helpful? Give feedback.
All reactions