Skip to content

Add larastan and fix static analysis issue #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexkart
Copy link
Contributor

@alexkart alexkart commented Apr 15, 2025

This pull request includes updates to the composer.json file to add a new development dependency and an improvement to the type hinting in the FiltersExact class.

It looks like this project uses larastan for static analysis but there is no dev dependency for larastan.

Issue fixed:

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Filters/FiltersExact.php                                                                                                                                              
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  72     Parameter #1 $query of method Spatie\QueryBuilder\Filters\FiltersExact<TModelClass of Illuminate\Database\Eloquent\Model>::__invoke() expects                             
         Illuminate\Database\Eloquent\Builder<TModelClass of Illuminate\Database\Eloquent\Model>, Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Model> given.  
         🪪  argument.type                                                                                                                                                         
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant