Skip to content

Iterate all sub directories instead of collecting all files at once. #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions src/DirectoryCleaner.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Spatie\DirectoryCleanup;

use Carbon\Carbon;
use Illuminate\Support\Collection;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Support\Collection;
use Spatie\DirectoryCleanup\Policies\CleanupPolicy;

class DirectoryCleaner
Expand All @@ -15,6 +15,9 @@ class DirectoryCleaner
/** @var string */
protected $directory;

/** @var Carbon */
protected $timeInPast;

public function __construct(Filesystem $filesystem)
{
$this->filesystem = $filesystem;
Expand All @@ -27,24 +30,41 @@ public function setDirectory(string $directory)
return $this;
}

public function deleteFilesOlderThanMinutes(int $minutes) : Collection
public function setMinutes($minutes)
{
$timeInPast = Carbon::now()->subMinutes($minutes);
$this->timeInPast = Carbon::now()->subMinutes($minutes);

return $this;
}

return collect($this->filesystem->allFiles($this->directory, true))
->filter(function ($file) use ($timeInPast) {
public function deleteFilesOlderThanMinutes($amountOfFilesDeleted = 0, $directory = null): int
{
$workingDir = $directory ?: realpath($this->directory);
$directories = collect($this->filesystem->directories($workingDir));
if ($directory === null) {
$directories = $directories->add($workingDir);
}

foreach ($directories as $subDirectory) {
$amountOfFilesDeleted = $this->deleteFilesOlderThanMinutes($amountOfFilesDeleted, $subDirectory);
}

$files = collect($this->filesystem->files($workingDir, true))
->filter(function ($file) {
return Carbon::createFromTimestamp(filemtime($file))
->lt($timeInPast);
->lt($this->timeInPast);
})
->filter(function ($file) {
return $this->policy()->shouldDelete($file);
})
->each(function ($file) {
$this->filesystem->delete($file);
});

return $amountOfFilesDeleted + $files->count();
}

public function deleteEmptySubdirectories() : Collection
public function deleteEmptySubdirectories(): Collection
{
return collect($this->filesystem->directories($this->directory))
->filter(function ($directory) {
Expand All @@ -55,7 +75,7 @@ public function deleteEmptySubdirectories() : Collection
});
}

protected function policy() : CleanupPolicy
protected function policy(): CleanupPolicy
{
return resolve(config(
'laravel-directory-cleanup.cleanup_policy',
Expand Down
3 changes: 2 additions & 1 deletion src/DirectoryCleanupCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ protected function deleteFilesIfOlderThanMinutes(string $directory, int $minutes
{
$deletedFiles = app(DirectoryCleaner::class)
->setDirectory($directory)
->setMinutes($minutes)
->deleteFilesOlderThanMinutes($minutes);

$this->info("Deleted {$deletedFiles->count()} file(s) from {$directory}.");
$this->info("Deleted {$deletedFiles} file(s) from {$directory}.");
}

protected function deleteEmptySubdirectories(string $directory)
Expand Down