Skip to content

Update all packages + replace Enzyme with Testing Library #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 25, 2020

Conversation

WesCossick
Copy link
Member

This PR updates all the packages in this repo to the latest available versions. Additionally, I've replaced Enzyme with Testing Library and applied some of our company's newer design patterns to the tests.

Note: The migration to Testing Library is not fully complete; the @testing-library/user-event package does not currently support arrow up/down keys. @corymharper is looking into submitting a PR to their repo to add this functionality.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #215 (55145f5) into master (284c3b0) will increase coverage by 2.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   82.14%   84.52%   +2.38%     
==========================================
  Files           1        1              
  Lines          84       84              
  Branches       22       22              
==========================================
+ Hits           69       71       +2     
+ Misses         15       13       -2     
Impacted Files Coverage Δ
src/use-dropdown-menu.ts 84.52% <100.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284c3b0...55145f5. Read the comment docs.

@WesCossick WesCossick marked this pull request as ready for review November 25, 2020 22:51
@WesCossick
Copy link
Member Author

I went ahead and used fireEvent() directly for any tests that need to use up/down arrow keys. We may end up using @testing-library/user-event in the future if they add support for up/down arrow keys.

@WesCossick WesCossick merged commit 7d66fbd into master Nov 25, 2020
@WesCossick WesCossick deleted the catch-up-to-speed branch November 25, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant