fix more code style

Author: mossplix

src/main/java/ug/sparkpl/momoapi/network/disbursements/DisbursementsClient.java

@@ -86,7 +86,7 @@ public DisbursementsClient(RequestOptions opts) {
 
 
   /**
-   * getToken
+   * getToken.
    *
    * @return AccessToken
    * @throws IOException when network error occurs
@@ -113,10 +113,10 @@ public Balance getBalance() throws IOException {
   }
 
   /**
-   * get Transaction
+   * get Transaction.
    *
-   * @param ref
-   * @return
+   * @param ref String
+   * @return Transaction
    * @throws IOException when there is a network error
    */
 
@@ -133,35 +133,35 @@ public Transaction getTransaction(String ref) throws IOException {
    * @param mobile       String
    * @param amount       String
    * @param externalId   String
-   * @param payee_note   String
+   * @param payeeNote    String
    * @param payerMessage String
    * @param currency     String
-   * @return
+   * @return String
    * @throws IOException when there is a network error
    */
   public String transfer(String mobile, String amount,
-                         String externalId, String payee_note,
+                         String externalId, String payeeNote,
                          String payerMessage, String currency) throws IOException {
-    Transfer rBody = new Transfer(mobile, amount, externalId, payee_note, payerMessage, currency);
+    Transfer rbody = new Transfer(mobile, amount, externalId, payeeNote, payerMessage, currency);
     String ref = UUID.randomUUID().toString();
-    this.apiService.transfer(rBody, ref).execute();
+    this.apiService.transfer(rbody, ref).execute();
     return ref;
 
   }
 
   /**
    * transfer money.
    *
-   * @param opts
+   * @param opts HashMap
    * @return String
    * @throws IOException when there is a network error
    */
   public String transfer(HashMap<String, String> opts) throws IOException {
-    Transfer rBody = new Transfer(opts.get("mobile"), opts.get("amount"),
+    Transfer rbody = new Transfer(opts.get("mobile"), opts.get("amount"),
         opts.get("externalId"), opts.get("payeeNote"),
         opts.get("payerMessage"), this.opts.getCurrency());
     String ref = UUID.randomUUID().toString();
-    this.apiService.transfer(rBody, ref).execute();
+    this.apiService.transfer(rbody, ref).execute();
     return ref;
 
   }

src/main/java/ug/sparkpl/momoapi/network/remittances/RemittancesApiService.java

@@ -16,36 +16,42 @@
 public interface RemittancesApiService {
 
   /**
-   * @param body
-   * @param ref
-   * @return
+   * transfer money.
+   *
+   * @param body Transfer
+   * @param ref  String
+   * @return Void
    */
   @POST("/remittance/v1_0/transfer/")
   @Headers("Content-Type: application/json")
   Call<Void> transfer(@Body Transfer body, @Header("X-Reference-Id") String ref);
 
   /**
-   * @param credentials
-   * @param subscriptionKey
-   * @return
+   * get Token.
+   *
+   * @param credentials     String
+   * @param subscriptionKey String
+   * @return AccessToken
    */
   @POST("/remittance/token/")
   @Headers("Content-Type: application/json")
   Call<AccessToken> getToken(@Header("Authorization") String credentials, @Header("Ocp-Apim-Subscription-Key") String subscriptionKey);
 
   /**
-   * Get Account Balance
+   * Get Account Balance.
    */
   @Headers("Content-Type: application/json")
   @GET("/remittance/v1_0/account/balance")
   Call<Balance> getBalance();
 
   /**
-   * @param transaction_id
-   * @return
+   * GetTransaction Status.
+   *
+   * @param transactionId
+   * @return Transaction
    */
-  @GET("/remittance/v1_0/transfer/{transaction_id}")
+  @GET("/remittance/v1_0/transfer/{transactionId}")
   @Headers("Content-Type: application/json")
-  Call<Transaction> getTransactionStatus(@Path("transaction_id") String transaction_id);
+  Call<Transaction> getTransactionStatus(@Path("transaction_id") String transactionId);
 
 }

src/main/java/ug/sparkpl/momoapi/network/remittances/RemittancesClient.java

@@ -135,10 +135,10 @@ public String transfer(String mobile, String amount,
                          String payeeNote,
                          String payerMessage,
                          String currency) throws IOException {
-    Transfer rBody = new Transfer(mobile, amount, externalId,
+    Transfer rbody = new Transfer(mobile, amount, externalId,
         payeeNote, payerMessage, currency);
     String ref = UUID.randomUUID().toString();
-    this.apiService.transfer(rBody, ref).execute();
+    this.apiService.transfer(rbody, ref).execute();
     return ref;
 
   }
@@ -151,12 +151,12 @@ public String transfer(String mobile, String amount,
    * @throws IOException when there is a network error
    */
   public String transfer(HashMap<String, String> opts) throws IOException {
-    Transfer rBody = new Transfer(opts.get("mobile"),
+    Transfer rbody = new Transfer(opts.get("mobile"),
         opts.get("amount"), opts.get("externalId"),
         opts.get("payeeNote"), opts.get("payerMessage"),
         opts.get("currency"));
     String ref = UUID.randomUUID().toString();
-    this.apiService.transfer(rBody, ref).execute();
+    this.apiService.transfer(rbody, ref).execute();
     return ref;
 
   }

src/test/java/ug/sparkpl/network/RequestOptionsTest.java

@@ -1,28 +1,29 @@
 package ug.sparkpl.network;
 
-import org.junit.jupiter.api.Test;
 import ug.sparkpl.momoapi.network.RequestOptions;
 
+import org.junit.jupiter.api.Test;
+
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class RequestOptionsTest {
 
   @Test
   public void testPersistentValuesInToBuilder() {
     RequestOptions.Builder opts = RequestOptions.builder()
-            .setCollectionApiSecret("sec")
-            .setCollectionPrimaryKey("123")
-            .setCollectionUserId("1234")
-            .setCurrency("UGX")
-            .setTargetEnvironment("test")
-            .setBaseUrl("new_base")
-            .setRemittanceUserId("remituid")
-            .setRemittancePrimaryKey("remKey")
-            .setRemittanceApiSecret("remSecret")
-            .setDisbursementUserId("duid")
-            .setRemittanceApiSecret("dSecret")
-            .setRemittancePrimaryKey("dKey")
-            .build().toBuilder();
+        .setCollectionApiSecret("sec")
+        .setCollectionPrimaryKey("123")
+        .setCollectionUserId("1234")
+        .setCurrency("UGX")
+        .setTargetEnvironment("test")
+        .setBaseUrl("new_base")
+        .setRemittanceUserId("remituid")
+        .setRemittancePrimaryKey("remKey")
+        .setRemittanceApiSecret("remSecret")
+        .setDisbursementUserId("duid")
+        .setDisbursementApiSecret("dSecret")
+        .setDisbursementPrimaryKey("dKey")
+        .build().toBuilder();
 
 
     // assuming these are stable across a given stripe integration