From 268923e0863b1d14ab6e8d8c3af4451a7673f29a Mon Sep 17 00:00:00 2001 From: Rob Trame Date: Mon, 13 Jun 2022 13:49:39 -0600 Subject: [PATCH 1/4] Add missing semicolon --- ext/sqlite3/database.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/sqlite3/database.c b/ext/sqlite3/database.c index 8f78a090..f9a25c89 100644 --- a/ext/sqlite3/database.c +++ b/ext/sqlite3/database.c @@ -79,7 +79,7 @@ static VALUE rb_sqlite3_disable_quirk_mode(VALUE self) return Qtrue; #else - return Qfalse + return Qfalse; #endif } From 818da5840369acd505759802290d19a930d613d9 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Tue, 14 Jun 2022 08:26:19 -0400 Subject: [PATCH 2/4] ci: run suite against a slightly older version of sqlite3 See #324 for more context --- .github/workflows/sqlite3-ruby.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/sqlite3-ruby.yml b/.github/workflows/sqlite3-ruby.yml index 49bf9388..86f5d8a2 100644 --- a/.github/workflows/sqlite3-ruby.yml +++ b/.github/workflows/sqlite3-ruby.yml @@ -63,3 +63,13 @@ jobs: run: bundle exec rake compile:msys2 - name: test run: bundle exec rake test + + ubuntu: + runs-on: ubuntu-latest + container: + image: ruby:2.7.5-buster # old enough to not support SQLITE_DBCONFIG_DQS_DDL + steps: + - uses: actions/checkout@v3 + - run: bundle install + - run: bundle exec rake compile + - run: bundle exec rake test From 661e9698b289d0e29cf2db93918d17ebaa6f8169 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Tue, 14 Jun 2022 08:40:23 -0400 Subject: [PATCH 3/4] test: skip strict mode test for sqlite < 3.29.0 Related to #317 / 40fb6cc --- test/test_database.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/test_database.rb b/test/test_database.rb index 8c3741ef..197d3838 100644 --- a/test/test_database.rb +++ b/test/test_database.rb @@ -512,6 +512,10 @@ def test_execute_with_named_bind_params end def test_strict_mode + unless Gem::Requirement.new(">= 3.29.0").satisfied_by?(Gem::Version.new(SQLite3::SQLITE_VERSION)) + skip("strict mode feature not available in #{SQLite3::SQLITE_VERSION}") + end + db = SQLite3::Database.new(':memory:') db.execute('create table numbers (val int);') db.execute('create index index_numbers_nope ON numbers ("nope");') # nothing raised From b2f0bed974d7625f9c60b6a4b6c7f4cfe4b400f1 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Tue, 14 Jun 2022 08:45:21 -0400 Subject: [PATCH 4/4] update CHANGELOG [skip ci] --- CHANGELOG.rdoc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.rdoc b/CHANGELOG.rdoc index 9d4181ad..7996114f 100644 --- a/CHANGELOG.rdoc +++ b/CHANGELOG.rdoc @@ -1,3 +1,9 @@ +=== 1.4.4 (unreleased) + +* Fixes + * Compilation no longer fails against SQLite3 versions < 3.29.0. This issue was introduced in v1.4.3. [#324] (Thank you, @r6e!) + + === 1.4.3 (2022-05-25) * Enhancements